[webkit-reviews] review granted: [Bug 89223] [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK : [Attachment 148083] Patch proposal

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 89223: [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
https://bugs.webkit.org/show_bug.cgi?id=89223

Attachment 148083: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=148083&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148083&action=review


looks good. a few minor nits

> Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:181
> +{

seems like you could probably implement this method pretty easily

> Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:256
> +    AtkObject* parent =  atk_object_get_parent(ATK_OBJECT(m_element));

extra white space after = sign

> Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:863
> +    // FIXME: implement

two FIXME's here

> Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:869
> +    // FIXME: implement

two FIXMEs here