[webkit-reviews] review requested: [Bug 90267] Handle SSL errors for SOUP : [Attachment 151088] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 6 08:49:17 PDT 2012


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 90267: Handle SSL errors for SOUP
https://bugs.webkit.org/show_bug.cgi?id=90267

Attachment 151088: New patch
https://bugs.webkit.org/attachment.cgi?id=151088&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
This is a new patch following a simpler approach based on what win port does.
It doesn't affect WebKit1, because in this case the wk layer should handle the
errors using the SoupSession object directly. If SoupSession is set to strict
mode, SSL errors will be handled by the SoupSession, otherwhise they will be
ignored, so it's exactly the same behaviour. For WebKit2 we are also ignoring
SSL errors by default for compatibility, but that will be removed once the UI
process can handle those errors. This patch doesn't change any cross-platform
code.


More information about the webkit-reviews mailing list