[webkit-reviews] review canceled: [Bug 90673] Avoid querying the font cache for the zero-width space glyph : [Attachment 151046] Patch

[bugzilla-daemon at webkit.org]

Pierre Rossi <pierre.rossi at gmail.com> has canceled Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 90673: Avoid querying the font cache for the zero-width space glyph
https://bugs.webkit.org/show_bug.cgi?id=90673

Attachment 151046: Patch
https://bugs.webkit.org/attachment.cgi?id=151046&action=review

------- Additional Comments from Pierre Rossi <pierre.rossi at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151046&action=review


I'm going to try to clarify this ChangeLog entry in the next iteration, along
with the necessary build fixes the EWS pointed out.

>> Source/WebCore/ChangeLog:11
>> +	    the character value.
> 
> Could you please explain why this is an improvement? How did you assess
performance impact?

The part that I believe to be an improvement is that it doesn't rely on each
port's implementation of FontCache::getFontDataForCharacters() in the case of
ZWSP. The example of the Qt port, where the mechanism used to get the glyph
index for a given character becomes moot for ZWSP made me wonder why we need to
store this particular glyph index in the first place.
I didn't bother to test things performance-wise to be honest, since it didn't
seem to me this change could have a negative impact, but I can be proven wrong.