[webkit-reviews] review denied: [Bug 90669] Fix loadRGBA8AsFloat to work with older GCC as well : [Attachment 151075] patch2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 6 06:39:27 PDT 2012


Zoltan Herczeg <zherczeg at webkit.org> has denied  review:
Bug 90669: Fix loadRGBA8AsFloat to work with older GCC as well
https://bugs.webkit.org/show_bug.cgi?id=90669

Attachment 151075: patch2
https://bugs.webkit.org/attachment.cgi?id=151075&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151075&action=review


> Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h:40
> -    uint32x2_t temporary1 = vset_lane_u32(*source, temporary1, 0);
> +    uint32x2_t temporary1 = vld1_u32(source);

I think vld1_u32 reads a whole register, which can lead to buffer overflow.


More information about the webkit-reviews mailing list