[webkit-reviews] review granted: [Bug 90677] Web Inspector: start searching from the cursor position in the Sources panel. : [Attachment 151066] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 90677: Web Inspector: start searching from the cursor position in the
Sources panel.
https://bugs.webkit.org/show_bug.cgi?id=90677

Attachment 151066: Patch
https://bugs.webkit.org/attachment.cgi?id=151066&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151066&action=review


> Source/WebCore/inspector/front-end/TextEditor.js:398
> +    lastSelection: function(textRange)

Please remove parameter and jsdoc.

> Source/WebCore/inspector/front-end/TextEditor.js:427
> +	       return;

We might want to set (non empty) selection for other external actions (e.g. for
Search across all files).
Consider moving the code responsible for turning selection into a cursor
position to the blur event handler instead.