[webkit-reviews] review granted: [Bug 90608] [CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute : [Attachment 150940] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 6 05:20:54 PDT 2012
Andreas Kling <kling at webkit.org> has granted Andrei Onea <onea at adobe.com>'s
request for review:
Bug 90608: [CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute
https://bugs.webkit.org/show_bug.cgi?id=90608
Attachment 150940: Patch
https://bugs.webkit.org/attachment.cgi?id=150940&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150940&action=review
r=me with tiny tweaks:
> LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index.html:18
> + description("Test for 90608: [CSSRegions]Implement
NamedFlow::firsEmptyRegionIndex attribute.");
Typo, firsEmptyRegionIndex.
> Source/WebCore/dom/WebKitNamedFlow.cpp:66
> + int index;
This variable should be scoped to the for loop below.
More information about the webkit-reviews
mailing list