[webkit-reviews] review denied: [Bug 90631] Web Inspector: display function scope in UI : [Attachment 151000] This is a draft only, please review on request only

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 90631: Web Inspector: display function scope in UI
https://bugs.webkit.org/show_bug.cgi?id=90631

Attachment 151000: This is a draft only, please review on request only
https://bugs.webkit.org/attachment.cgi?id=151000&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151000&action=review


> Source/WebCore/ChangeLog:8
> +	   TBD

Please fill in the change description.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:251
> +	       if (this.property.value.type == "function") {

We use === in the front-end code, also no braces for one-line blocks.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:500
> +		   var subtitle = " ";

I'd rather assign it to null here.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:502
> +		   switch (scope.type) {

style nit: "A case label should line up with its switch statement"

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:544
> +	   this.hasChildren = true;

Why not initialize this in the constructor?