[webkit-reviews] review granted: [Bug 83865] [EFL] Add Web Inspector to WebKit-EFL : [Attachment 150913] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Seokju Kwon
<seokju.kwon at samsung.com>'s request for review:
Bug 83865: [EFL] Add Web Inspector to WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=83865

Attachment 150913: Patch
https://bugs.webkit.org/attachment.cgi?id=150913&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This looks sane to me. There is a lot of detail in the plumbing implementation,
but if you followed the Qt or Gtk code, you should be fine. Please test
following scenarios of closing the inspector prior to landing:
1) via closing inspector view
2) via clicking inspector's close button
3) make sure that inspector closes upon inspected view close.

You should be able to re-open inspector for these cases. Also, make sure things
are working for multiple tabs and inspected page reloads. I think it is safe to
land this as a first cut and follow up with the bugfixes as problems arise.