[webkit-reviews] review granted: [Bug 90347] Inline property storage should not be wasted when it is exhausted : [Attachment 150861] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 90347: Inline property storage should not be wasted when it is exhausted
https://bugs.webkit.org/show_bug.cgi?id=90347

Attachment 150861: the patch
https://bugs.webkit.org/attachment.cgi?id=150861&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150861&action=review


Agreed that that it would be nice to consider a class in the future, and even
though it's not from code you added it would be good to fix the preexisting
style issues re duplicate names.

> Source/JavaScriptCore/runtime/Options.cpp:121
> +#define FOR_EACH_OPTION(type_, name_, defaultValue_)    \

extra whitespace! r-!

>> Source/JavaScriptCore/runtime/Options.cpp:138
>> +#endif
> 
> Line contains only semicolon. If this should be an empty statement, use { }
instead.  [whitespace/semicolon] [5]

Technically we don't allow #if 0 code, so this is on pretty shaky ground, but
Im prepared to look the other way if this helps.