[webkit-reviews] review denied: [Bug 90529] Web Inspector: Add FileContentView for FileSystemView : [Attachment 150738] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 90529: Web Inspector: Add FileContentView for FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=90529

Attachment 150738: Patch
https://bugs.webkit.org/attachment.cgi?id=150738&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150738&action=review


> Source/WebCore/inspector/front-end/FileContentView.js:49
> +	       if (this._file.resourceType.isTextType())

You should use another way to detect text files, see
https://bugs.webkit.org/show_bug.cgi?id=90518 for details.

> Source/WebCore/inspector/front-end/FileContentView.js:61
> +	   if (errorCode !== 0 || !metadata)

if (errorCode || !metadata)

> Source/WebCore/inspector/front-end/FileContentView.js:82
> +	   if (this._file.resourceType.isTextType())

Ditto.

> Source/WebCore/inspector/front-end/FileContentView.js:95
> +WebInspector.FileContentView.Content = function(file, metadata)

WebInspector.FileContentProvider
I would move all this logic to WebInspector.FileSystemModel.File actually.

> Source/WebCore/inspector/front-end/FileSystemView.js:114
> +	       if (this._entry.isDirectory) {

Please remove braces.

> Source/WebCore/inspector/front-end/FileSystemView.js:196
> +	   } else {

No braces for one liners.