[webkit-reviews] review denied: [Bug 90518] Web Inspector: Add OtherText resourceType and text/plain tokenizer : [Attachment 150722] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 90518: Web Inspector: Add OtherText resourceType and text/plain tokenizer
https://bugs.webkit.org/show_bug.cgi?id=90518

Attachment 150722: Patch
https://bugs.webkit.org/attachment.cgi?id=150722&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150722&action=review


> Source/WebCore/ChangeLog:3
> +	   Web Inspector: Add OtherText resource type and text/plain tokenizer

I don't think we should add another resource type for this. Resource type are
essentially duplicating CachedResource types and we don't want to extend this
list.
You should use Other instead.
Backend could decide whether file has text content or not based on the mime
type. Binary content should be served to frontend base64 encoded.
(We already have some text detecting heuristics in NetworkResourcesData:
http://code.google.com/p/chromium/source/search?q=file%3Ainspector+%22.mimetype
+%3D+%22&origq=file%3Ainspector+%22.mimetype+%3D+%22&btnG=Search+Trunk )
Frontend can then show content as text if it is not base64 encoded.