[webkit-reviews] review granted: [Bug 90619] Code refactoring: move mimeTypeFromUTITree to a separate file. : [Attachment 150958] Patch, fix style violation in UTIUtilities.h.

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 90619: Code refactoring: move mimeTypeFromUTITree to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=90619

Attachment 150958: Patch, fix style violation in UTIUtilities.h.
https://bugs.webkit.org/attachment.cgi?id=150958&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150958&action=review


r=me with the clause 3 license fixes.  (The WebCore Xcode project items are
just nits I noticed, but can be checked in with this commit, or separately.)

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:7958
> -		333F704F0FB49CA2008E12A6 /* Notification.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
Notification.h; path =Modules/notifications/Notification.h; sourceTree =
"<group>"; };
> +		333F704F0FB49CA2008E12A6 /* Notification.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
Notification.h; path = Modules/notifications/Notification.h; sourceTree =
"<group>"; };

NOTE: Drive-by fix that happened when editing the Xcode project file.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:28176
> -				A8CCBB4C151F833B00AB7CE9 /*
WorkerContextWebDatabase.cpp in Sources */, F34742E01343631F00531BC2 /*
WorkerDebuggerAgent.cpp in Sources */,
> +				A8CCBB4C151F833B00AB7CE9 /*
WorkerContextWebDatabase.cpp in Sources */,
> +				F34742E01343631F00531BC2 /*
WorkerDebuggerAgent.cpp in Sources */,

NOTE: Drive-by fix that happened when editing the Xcode project file.

> Source/WebCore/platform/network/mac/UTIUtilities.h:15
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *	  its contributors may be used to endorse or promote products derived
> + *	  from this software without specific prior written permission. 

This is the old Apple license.	The one in Source/WebCore/LICENSE-APPLE doesn't
include clause 3 anymore.  Please remove clause 3.

> Source/WebCore/platform/network/mac/UTIUtilities.mm:15
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *	  its contributors may be used to endorse or promote products derived
> + *	  from this software without specific prior written permission. 

Ditto re: removing clause 3.