[webkit-reviews] review denied: [Bug 90610] Web Inspector: move search field to the bottom of the page. : [Attachment 150942] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 90610: Web Inspector: move search field to the bottom of the page.
https://bugs.webkit.org/show_bug.cgi?id=90610

Attachment 150942: Patch
https://bugs.webkit.org/attachment.cgi?id=150942&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150942&action=review


Please make label and input font size the same.

> Source/WebCore/inspector/front-end/SearchController.js:-220
> -	       // If focus belongs here and text is empty - nothing to do,
return unhandled.

We need a close button on the footer as well.

> Source/WebCore/inspector/front-end/inspector.css:300
> +.toolbar-search-navigation-hidden {

Is this style used somewhere?

> Source/WebCore/inspector/front-end/inspector.css:462
>  .status-bar {

Please revert this.