[webkit-reviews] review granted: [Bug 90591] [BlackBerry] A small typo fix in ResourceRequest.h : [Attachment 150889] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 5 07:03:23 PDT 2012
Rob Buis <rwlbuis at gmail.com> has granted Mary Wu <mary.wu at torchmobile.com.cn>'s
request for review:
Bug 90591: [BlackBerry] A small typo fix in ResourceRequest.h
https://bugs.webkit.org/show_bug.cgi?id=90591
Attachment 150889: Patch
https://bugs.webkit.org/attachment.cgi?id=150889&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150889&action=review
Fix is good, explanation could be improved :)
> Source/WebCore/ChangeLog:3
> + [BlackBerry] A small typo fix in ResourceRequest.h
The bug title is not correct, this is not a typo!
> Source/WebCore/ChangeLog:7
> +
You could add something like "Make setForceDownload a setter method."
Also, is this API used yet? If so, you could indicate which current use-case it
fixes.
More information about the webkit-reviews
mailing list