[webkit-reviews] review granted: [Bug 90166] NEON intrinsics should be used with gaussian blur filter : [Attachment 150605] patch3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 5 05:05:34 PDT 2012


Zoltan Herczeg <zherczeg at webkit.org> has granted Gabor Rapcsanyi
<rgabor at webkit.org>'s request for review:
Bug 90166: NEON intrinsics should be used with gaussian blur filter
https://bugs.webkit.org/show_bug.cgi?id=90166

Attachment 150605: patch3
https://bugs.webkit.org/attachment.cgi?id=150605&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
r=me

View in context: https://bugs.webkit.org/attachment.cgi?id=150605&action=review


> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:127
> +		   boxBlur(src, dst, kernelSizeX, dxLeft, dxRight, 4, stride,
paintSize.width(), paintSize.height(), isAlphaImage());

isAlphaImage() is true here!

> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:140
> +		   boxBlur(src, dst, kernelSizeY, dyLeft, dyRight, stride, 4,
paintSize.height(), paintSize.width(), isAlphaImage());

ditto.


More information about the webkit-reviews mailing list