[webkit-reviews] review requested: [Bug 88654] SVG filter's SourceGraphic is clipped to the screen size : [Attachment 150890] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 5 01:41:20 PDT 2012


Czene Tamas <tczene at inf.u-szeged.hu> has asked	for review:
Bug 88654: SVG filter's SourceGraphic is clipped to the screen size
https://bugs.webkit.org/show_bug.cgi?id=88654

Attachment 150890: proposed patch
https://bugs.webkit.org/attachment.cgi?id=150890&action=review

------- Additional Comments from Czene Tamas <tczene at inf.u-szeged.hu>
If SourceGraphic gets the image by the information of paintInfo and the image
is larger than the screen itself, then sourceGraphic gets the size of the
original image but only the pixels that are visible are painted to
sourceGraphic. So filters are applied on the size of the original image but the
only valid information of that is the clipped image (that has the size of the
screen). Therefore if the image is larger than the screen and we scroll to
another part of the image we don't see it because it doesn't get into the
sourceGraphic.
But if we set 
rect = IntRect(IntPoint(), sourceGraphic->logicalSize());
then sourceGraphic will get the whole image.


More information about the webkit-reviews mailing list