[webkit-reviews] review denied: [Bug 89554] Web Inspector: Having a "Scroll into view" for nodes through web inspector. : [Attachment 150877] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied sam <dsam2912 at gmail.com>'s
request for review:
Bug 89554: Web Inspector: Having a "Scroll into view" for nodes through web
inspector.
https://bugs.webkit.org/show_bug.cgi?id=89554

Attachment 150877: Patch
https://bugs.webkit.org/attachment.cgi?id=150877&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150877&action=review


Looks good. Couple of nits and it is ready to land.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1920
> +    scrollIntoView: function()

Should be private (_scrollIntoView)

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1930
> +		   object.callFunction(scrollIntoView, undefined);

No need to pass undefined, just declare this parameter as optional.

> Source/WebCore/inspector/front-end/RemoteObject.js:287
> +	       if (!callback)

You need to declare callback optional in the jsdoc.