[webkit-reviews] review granted: [Bug 90494] Implement device metrics for blackberry : [Attachment 150808] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 09:53:38 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Hanna <hanma at rim.com>'s request for
review:
Bug 90494: Implement device metrics for blackberry
https://bugs.webkit.org/show_bug.cgi?id=90494

Attachment 150808: Patch
https://bugs.webkit.org/attachment.cgi?id=150808&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150808&action=review


LGTM.

> Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:93
> +void InspectorClientBlackBerry::overrideDeviceMetrics(int width, int height,
float fontScaleFactor, bool fitWindow)

fitWindow not used, so you can remove the name.


More information about the webkit-reviews mailing list