[webkit-reviews] review granted: [Bug 90544] Stop tracking line number in tokenizer : [Attachment 150775] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 08:20:36 PDT 2012


Adam Barth <abarth at webkit.org> has granted Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 90544: Stop tracking line number in tokenizer
https://bugs.webkit.org/show_bug.cgi?id=90544

Attachment 150775: Patch
https://bugs.webkit.org/attachment.cgi?id=150775&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150775&action=review


This looks great.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:452
> +    const SegmentedString& currentString = m_input.current();
> +    return currentString.currentLine();

I would just combine these two lines to avoid having the temporary.


More information about the webkit-reviews mailing list