[webkit-reviews] review denied: [Bug 90270] [BlackBerry] crash in CookieDatabaseBackingStore. : [Attachment 150135] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 4 07:28:06 PDT 2012
Rob Buis <rwlbuis at gmail.com> has denied Jason <jason.liu at torchmobile.com.cn>'s
request for review:
Bug 90270: [BlackBerry] crash in CookieDatabaseBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=90270
Attachment 150135: Patch
https://bugs.webkit.org/attachment.cgi?id=150135&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150135&action=review
R- for now, please mention internal PR and reword the ChangeLog a bit.
>> Source/WebCore/ChangeLog:10
>> + No new tests, behavior has not changed.
>
> Not strictly true, behavior has changed for when cookies is null.
I still think you need to explain better, maybe have somebody in the office
help you with the ChangeLog?
More information about the webkit-reviews
mailing list