[webkit-reviews] review granted: [Bug 86630] Web Inspector: Emulate pseudo styles (hover etc.) of non-selected elements : [Attachment 150779] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 86630: Web Inspector: Emulate pseudo styles (hover etc.) of non-selected
elements
https://bugs.webkit.org/show_bug.cgi?id=86630

Attachment 150779: Patch
https://bugs.webkit.org/attachment.cgi?id=150779&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150779&action=review


> Source/WebCore/English.lproj/localizedStrings.js:20
> +localizedStrings["%d descendant with forced pseudo state"] = "%d descendant
with forced pseudo state";

i think you should remove the "pseudo" part from all the captions.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:537
> +    if (m_nodeIdToForcedPseudoState.isEmpty())

I don't think you need this check, it'll return later.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:1048
> +	   Element* element =
static_cast<Element*>(m_domAgent->nodeForId(it->first));

toElement

> Source/WebCore/inspector/InspectorCSSAgent.h:144
> +    int boundNodeId(Node* node) { return m_domAgent->boundNodeId(node); }

I'd implement it in .cpp

> Source/WebCore/inspector/front-end/ElementsPanel.js:195
> +	   this.treeOutline.updateOpenCloseTags(node);

It would be great if this was driven by the events.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:40
> +WebInspector.ElementsTreeOutline = function(omitRootDOMNode, selectEnabled,
showInElementsPanelEnabled, contextMenuCallback, setPseudoClassCallback)

I would introduce WebInspector.DOMAgent.prototype.addUserPropertyListener(name,
listener) to resolve this dependency.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:194
> +    updateOpenCloseTags: function(node)

This will become private.