[webkit-reviews] review denied: [Bug 89586] Web Inspector: Add support for keyboard increment / decrement on numbers in attributes in Elements Panel : [Attachment 150760] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 89586: Web Inspector: Add support for keyboard increment / decrement on
numbers in attributes in Elements Panel
https://bugs.webkit.org/show_bug.cgi?id=89586

Attachment 150760: Patch
https://bugs.webkit.org/attachment.cgi?id=150760&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150760&action=review


> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1193
> +	   function handleKeyDownEvent(event)

This looks like a lot of copy-paste. Could you extract this functionality from
the styles sidebar and make it re-usable instead?