[webkit-reviews] review denied: [Bug 90432] Remove inline keywords from functions which can not be inlined in ComposedShadowTreeWalker : [Attachment 150536] remove inline.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 02:24:34 PDT 2012


Hajime Morrita <morrita at google.com> has denied Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 90432: Remove inline keywords from functions which can not be inlined in
ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=90432

Attachment 150536: remove inline.
https://bugs.webkit.org/attachment.cgi?id=150536&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
No, this is actually intended to be inlined.
These functions are private, and called only from this file, thus can be
inlined.
And this inlining impacts NodRenderingContext speed.


More information about the webkit-reviews mailing list