[webkit-reviews] review granted: [Bug 90416] webkitpy: lint code in webkitpy.layout_tests.models : [Attachment 150506] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 90416: webkitpy: lint code in webkitpy.layout_tests.models
https://bugs.webkit.org/show_bug.cgi?id=90416

Attachment 150506: Patch
https://bugs.webkit.org/attachment.cgi?id=150506&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150506&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:215
> +	       indices[i] += 1	# pylint: disable=W0631
> +	       for j in range(i + 1, r):  # pylint: disable=W0631

What is the complaint here? Can we just fix it?

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:405
> +	   self.name = None  # this is the path in the line itself
> +	   self.path = None  # this is the normpath of self.name

Can you put a FIXME to rename these? original_path and normalize_path sgtm.

> Tools/Scripts/webkitpy/layout_tests/models/test_failures.py:115
> +	   super(FailureTimeout, self).__init__()

IIRC, there's some issue with use super. I don't remember what it was, but
everywhere else in webkitpy that I remember we just call the super-class
directly. I think we probably should do that here for consistency sake at
least.