[webkit-reviews] review granted: [Bug 90504] Improve webkit-patch rebaseline to work for more cases : [Attachment 150684] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 90504: Improve webkit-patch rebaseline to work for more cases
https://bugs.webkit.org/show_bug.cgi?id=90504

Attachment 150684: Patch
https://bugs.webkit.org/attachment.cgi?id=150684&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150684&action=review


> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:378
> +	       optparse.make_option("--test", help="Test to rebaseline"),

should we support multiple tests and/or builders here?

It seems like if you don't specify either --builder or --test, then we will
prompt the user for each builder and then prompt for the tests on the builder,
and that could be pretty annoying, so I'm not sure that this is a great design,
but I'm happy to try it out and see.