[webkit-reviews] review granted: [Bug 90503] nrwt: clean up exception handling and make sure we log some more failures : [Attachment 150683] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 90503: nrwt: clean up exception handling and make sure we log some more
failures
https://bugs.webkit.org/show_bug.cgi?id=90503

Attachment 150683: Patch
https://bugs.webkit.org/attachment.cgi?id=150683&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150683&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:120
> +		   # happenss (and log the appropriate messages).

happens

> Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:198
> +	   driver = self._driver
> +	   self._driver = None
> +	   if driver:
>	       _log.debug("%s killing driver" % self._name)
> -	       self._driver.stop()
> -	       self._driver = None
> +	       driver.stop()

We don't need to worry about thread-safety, right? In that case, couldn't you
just move the self._drive = None line to being right after the if statement?
Then you wouldn't need the local variable. Not a big deal, just a little easier
to read.