[webkit-reviews] review denied: [Bug 90497] [Qt] When building WebKit with Qt5+minimal, WebGL should be enabled : [Attachment 150671] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 90497: [Qt] When building WebKit with Qt5+minimal, WebGL should be enabled
https://bugs.webkit.org/show_bug.cgi?id=90497

Attachment 150671: Patch
https://bugs.webkit.org/attachment.cgi?id=150671&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150671&action=review


> Tools/ChangeLog:6
> +	   WebGL-related code (GraphicsContext3D etc.) is now used as part of
TextureMapperGL's path.

We should untangle this so that you can build with ENABLE_WEBGL=0 and still
have TextureMapperGL work.

> Tools/qmake/mkspecs/features/features.prf:200
> +    root_project_file: message("WebGL code is part of the rendering	with
Qt5. Overriding --no-webgl option.")

This seems upside-down to me? We shouldn't try to fix the entanglement by
entangling it more.