[webkit-reviews] review granted: [Bug 90409] nrwt: make the worker class stand alone with a cleaner interface : [Attachment 150491] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 90409: nrwt: make the worker class stand alone with a cleaner interface
https://bugs.webkit.org/show_bug.cgi?id=90409

Attachment 150491: Patch
https://bugs.webkit.org/attachment.cgi?id=150491&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150491&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:64
>      def safe_init(self):

I know you're not defining this method now, but this name doesn't match what it
does to me. I would think "safe" would mean we can call it whenever we want,
but it actually means we can only call it if the object doesn't need to be
pickled. Should we just call this init_unpicklable_state? It's kinda verbose,
but it's much more clear what it's doing.