[webkit-reviews] review granted: [Bug 88655] Font Boosting: Add basic framework : [Attachment 150571] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted John Mellor <johnme at chromium.org>'s
request for review:
Bug 88655: Font Boosting: Add basic framework
https://bugs.webkit.org/show_bug.cgi?id=88655

Attachment 150571: Patch
https://bugs.webkit.org/attachment.cgi?id=150571&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150571&action=review


This LGTM.  I'm excited for the next patch which makes this into a runtime
setting so we can actually test this!

> Source/WebCore/rendering/FontBoosting.cpp:19
> +/*
> + * Copyright (C) 2012 Google Inc. All rights reserved.
> + * Copyright (C) 2012 Apple Inc. All rights reserved.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License

> + * along with this library; see the file COPYING.LIB.  If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.
> + */

Did you intend to make this LGPL instead of BSD?  It doesn't matter, but I
think most new code from Google is BSD.... Or did this come from Apple somehow?
 (iOS?)  Again, it doesn't matter, just checking.