[webkit-reviews] review granted: [Bug 89900] Unneeded tree walking when adding or removing children due to RenderCounter / RenderQuote logic : [Attachment 150511] Patch

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Elliott Sprehn
<esprehn at gmail.com>'s request for review:
Bug 89900: Unneeded tree walking when adding or removing children due to
RenderCounter / RenderQuote logic
https://bugs.webkit.org/show_bug.cgi?id=89900

Attachment 150511: Patch
https://bugs.webkit.org/attachment.cgi?id=150511&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150511&action=review


Looks good. Lets leave the patch for today so that the other cced reviewers can
comment if needed.

> Source/WebCore/rendering/RenderQuote.cpp:69
> +    if (!documentBeingDestroyed()) {

The comment is not required and this could be better read as 

if (RenderView* view = this->view())
    view->removeRenderQuote();

since
ALWAYS_INLINE RenderView* RenderObject::view() const
{
    return toRenderView(document()->renderer());
}

and 

inline bool RenderObject::documentBeingDestroyed() const
{
    return !document()->renderer();
}

Same change for RenderCounter.