[webkit-reviews] review granted: [Bug 90422] [BlackBerry] Enable registerProtocolHandler for Blackberry : [Attachment 150515] Patch part 1/3 - Enable RegisterProtocolHandler and stub out

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 07:56:06 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted George Staikos <staikos at kde.org>'s
request for review:
Bug 90422: [BlackBerry] Enable registerProtocolHandler for Blackberry
https://bugs.webkit.org/show_bug.cgi?id=90422

Attachment 150515: Patch part 1/3 - Enable RegisterProtocolHandler and stub out
https://bugs.webkit.org/attachment.cgi?id=150515&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150515&action=review


LGTM.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:814
> +void ChromeClientBlackBerry::registerProtocolHandler(const WTF::String&,
const WTF::String&, const WTF::String&, const WTF::String&)

You probably do not need the WTF prefixes.


More information about the webkit-reviews mailing list