[webkit-reviews] review requested: [Bug 90166] NEON intrinsics should be used with gaussian blur filter : [Attachment 150605] patch3

[bugzilla-daemon at webkit.org]

Gabor Rapcsanyi <rgabor at webkit.org> has asked  for review:
Bug 90166: NEON intrinsics should be used with gaussian blur filter
https://bugs.webkit.org/show_bug.cgi?id=90166

Attachment 150605: patch3
https://bugs.webkit.org/attachment.cgi?id=150605&action=review

------- Additional Comments from Gabor Rapcsanyi <rgabor at webkit.org>
(In reply to comment #5)
> (From update of attachment 150397 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=150397&action=review
> 
> > Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:127
> > +		 if (!isAlphaImage())
> > +		     boxBlurNEON(src, dst, kernelSizeX, dxLeft, dxRight, 4,
stride, paintSize.width(), paintSize.height(), isAlphaImage());
> > +		 else
> > +		     boxBlur(src, dst, kernelSizeX, dxLeft, dxRight, 4, stride,
paintSize.width(), paintSize.height(), isAlphaImage());
> 
> Since isAlphaImage() is known at this point, we should pass true to boxBlur
and remove the bool argument from boxBlurNEON. If we ever make an alpha based
version, it will have a different name, since the code cannot be shared.

Yes, I removed it.

> 
> > Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h:32
> > +using namespace std;
> 
> We should not add using to a header file... We should use std:: if it is
really needed.

Removed as well.