[webkit-reviews] review denied: [Bug 90456] Web Inspector: Count inspector memory used to traverse DOM in native memory snapshots. : [Attachment 150596] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 06:43:02 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 90456: Web Inspector: Count inspector memory used to traverse DOM in native
memory snapshots.
https://bugs.webkit.org/show_bug.cgi?id=90456

Attachment 150596: Patch
https://bugs.webkit.org/attachment.cgi?id=150596&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150596&action=review


> Source/WebCore/inspector/InspectorMemoryAgent.cpp:446
> +    return sizeof(ContainerType) + container.capacity() * sizeof(typename
ContainerType::ValueType);

Please use the code for calculating container size from MemoryInstrumentation
to avoid duplication, r- for this.

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:614
> +    inspectorData.countSize(ScriptProfiler::profilerSnapshotsSize());

What about reporting profile and visited nodes map sizes as separate children
of InspectorData block?


More information about the webkit-reviews mailing list