[webkit-reviews] review granted: [Bug 89584] Web Inspector: Forward message loop instrumentation data to frontend. : [Attachment 150201] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 05:56:37 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 89584: Web Inspector: Forward message loop instrumentation data to
frontend.
https://bugs.webkit.org/show_bug.cgi?id=89584

Attachment 150201: Patch
https://bugs.webkit.org/attachment.cgi?id=150201&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150201&action=review


> Source/WebCore/ChangeLog:9
> +	   Now "Program" should be a top-level event where appropriate.

Could you please elaborate on what "appropriate" means.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:212
>	   var recordTypes = WebInspector.TimelineModel.RecordType;

There is only one usage, inline this?


More information about the webkit-reviews mailing list