[webkit-reviews] review granted: [Bug 90067] [EFL][WK2] Add API to deliver a Web Intent to a frame : [Attachment 150394] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 90067: [EFL][WK2] Add API to deliver a Web Intent to a frame
https://bugs.webkit.org/show_bug.cgi?id=90067

Attachment 150394: Patch
https://bugs.webkit.org/attachment.cgi?id=150394&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150394&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_intent.cpp:199
> +WKIntentDataRef ewk_intent_WKIntentDataRef_get(const Ewk_Intent* intent)
> +{
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(intent, 0);
> +    return intent->wkIntent.get();
> +}

Does it really make sense to create this as a separate method?

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:201
> +EAPI Eina_Bool    ewk_view_intent_deliver(Evas_Object *o, Ewk_Intent
*intent);

I was wondering whether _post would make more sense due to consistency