[webkit-reviews] review granted: [Bug 90066] [EFL][WK2] Add API to inspect a Web Intent service : [Attachment 150396] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 90066: [EFL][WK2] Add API to inspect a Web Intent service
https://bugs.webkit.org/show_bug.cgi?id=90066

Attachment 150396: Patch
https://bugs.webkit.org/attachment.cgi?id=150396&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150396&action=review


LGTM

> Source/WebKit2/UIProcess/API/efl/ewk_intent_service.cpp:48
> +    unsigned int __ref; /**< the reference count of the object */
> +#if ENABLE(WEB_INTENTS_TAG)
> +    WKRetainPtr<WKIntentServiceInfoRef> wkService;
> +#endif
> +    const char* action;

Should this whole thing exist if that is not enabled? I mean the struct wont
have the same size anyway

> Source/WebKit2/UIProcess/API/efl/ewk_intent_service.cpp:87
> +    delete service;

are you creating this with 'new'?

> Source/WebKit2/UIProcess/API/efl/ewk_intent_service.cpp:169
> +    ewkIntentService->wkService = wkService;
> +    return ewkIntentService;

I prefer a newline before return to make it easier to spot