[webkit-reviews] review granted: [Bug 90401] Compositing layer sync should cause deferred repaints to be fired immediately : [Attachment 150475] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 90401: Compositing layer sync should cause deferred repaints to be fired
immediately
https://bugs.webkit.org/show_bug.cgi?id=90401

Attachment 150475: patch
https://bugs.webkit.org/attachment.cgi?id=150475&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150475&action=review


> Source/WebCore/page/FrameView.cpp:752
>      root->compositor()->flushPendingLayerChanges(rootFrameForSync ==
m_frame);
>  
> +    // If we sync compositing layers and allow the repaint to be deferred,
there is time for a
> +    // visible flash to occur. Instead, stop the deferred repaint timer and
repaint immediately.
> +    stopDelayingDeferredRepaints();

I think we should swap these around.

If deferred repaints at some point affects compositing layers (it does not
yet), then we'd want those repaints to get flushed.