[webkit-reviews] review denied: [Bug 89392] [Chromium] Notify the embedder when the page scale changes : [Attachment 148188] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 89392: [Chromium] Notify the embedder when the page scale changes
https://bugs.webkit.org/show_bug.cgi?id=89392

Attachment 148188: Patch
https://bugs.webkit.org/attachment.cgi?id=148188&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
jamesr and I spoke about this patch at length.	The approach in this patch
isn't great because this patch essentially creates to notification paths for
the page scale information to reach the browser's UI thread:

1) These callbacks.
2) The images drawn by the compositor.

Having two asynchronous notification paths is problematic because the messages
arriving on these two paths will be inconsistent and lead to janky UI.	At a
better approach is to send this information along the compositor's notification
path so that it is synchronized with the images actually being displayed by the
compositor.

James recommends looking at WebCompositorInputHandler and
WebCompositorInputHandlerClient to see how we might follow that approach.