[webkit-reviews] review granted: [Bug 82461] [Chromium] Implement a Layout Test for editing/SurroundingText : [Attachment 150453] Patch

Mon Jul 2 12:19:24 PDT 2012

Ryosuke Niwa <rniwa at webkit.org> has granted Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 82461: [Chromium] Implement a Layout Test for editing/SurroundingText
https://bugs.webkit.org/show_bug.cgi?id=82461

Attachment 150453: Patch
https://bugs.webkit.org/attachment.cgi?id=150453&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150453&action=review

Please fix the header include order before landing it.

>
LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text.html:6
> +<head>
> +<meta charset="utf-8">
> +<script src="../../../../fast/js/resources/js-test-pre.js"></script>
> +</head>

Since we don't need to specify charset in this test, you can move the script
element to body.

>
LayoutTests/platform/chromium/editing/surrounding-text/surrounding-text.html:12

> +<script type="text/javascript">

Type attribute is unnecessary.