[webkit-reviews] review granted: [Bug 87610] The eventSender.beginDragWithFiles had been implemented in windows, related tests listed in LayoutTests/platform/win/Skipped should be rebaselined : [Attachment 150327] patch

[bugzilla-daemon at webkit.org]

Jessie Berlin <jberlin at webkit.org> has granted huangxueqing
<huangxueqing at baidu.com>'s request for review:
Bug 87610: The eventSender.beginDragWithFiles had been implemented in windows,
related tests listed in LayoutTests/platform/win/Skipped should be rebaselined
https://bugs.webkit.org/show_bug.cgi?id=87610

Attachment 150327: patch
https://bugs.webkit.org/attachment.cgi?id=150327&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150327&action=review


r=me with the fixes I mentioned :)

> LayoutTests/platform/win/Skipped:249
> +# hit ASSERT(url == m_string) in KURL::KURL

Sorry if I wasn't clear about this last time. You should file a bug about this
issue and include the bug number in the Skipped list so that somebody looking
at the Skipped list can see more details and if any progress has been made on
that bug.

> LayoutTests/platform/win/Skipped:252
> +# file size did not be retrieved via relative path

Ditto.