[webkit-reviews] review granted: [Bug 87252] [EFL] Add run API tests as a step on the build bots : [Attachment 150421] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 2 11:52:18 PDT 2012


Daniel Bates <dbates at webkit.org> has granted Thiago Marcos P. Santos
<tmpsantos at gmail.com>'s request for review:
Bug 87252: [EFL] Add run API tests as a step on the build bots
https://bugs.webkit.org/show_bug.cgi?id=87252

Attachment 150421: Patch
https://bugs.webkit.org/attachment.cgi?id=150421&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150421&action=review


> Tools/Scripts/run-efl-tests:38
> +$ENV{CTEST_OUTPUT_ON_FAILURE}="1";

Nit: Missing space characters on both sides of the equality sign (=).

> Tools/Scripts/run-efl-tests:41
> +exit exitStatus(0);

This line isn't necessary as Perl exits with exit status 0 by default.


More information about the webkit-reviews mailing list