[webkit-reviews] review granted: [Bug 90171] MediaStream API: Update MediaStreamTrackList to match the specification : [Attachment 150400] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 90171: MediaStream API: Update MediaStreamTrackList to match the
specification
https://bugs.webkit.org/show_bug.cgi?id=90171

Attachment 150400: Patch
https://bugs.webkit.org/attachment.cgi?id=150400&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150400&action=review


Thanks!

> Source/WebCore/Modules/mediastream/MediaStreamTrackList.cpp:128
> +    size_t index = notFound;
> +    for (unsigned i = 0; i < m_trackVector.size(); ++i) {
> +	   if (m_trackVector[i]->component() == component) {
> +	       index = i;
> +	       break;
> +	   }
> +    }

I would have put this code in m_trackVector, but I'm not sure it matters.