[webkit-reviews] review denied: [Bug 82461] [Chromium] Implement a Layout Test for editing/SurroundingText : [Attachment 150444] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied  review:
Bug 82461: [Chromium] Implement a Layout Test for editing/SurroundingText
https://bugs.webkit.org/show_bug.cgi?id=82461

Attachment 150444: Patch
https://bugs.webkit.org/attachment.cgi?id=150444&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150444&action=review


> Source/WebKit/chromium/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).

This line should appear before the description.

> Tools/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).

Ditto.

> Tools/DumpRenderTree/chromium/WebViewHost.h:132
> +    WebKit::WebString textSurroundingElement(const WebKit::WebNode&,
unsigned offset, unsigned maxLength);
> +

Why are we adding this to WebView?

> LayoutTests/ChangeLog:11
> +	   * platform/chromium/fast/text/surrounding-text-expected.txt: Added.
> +	   * platform/chromium/fast/text/surrounding-text.html: Added.

This test doesn't belong in fast/text. It should be in editing.