[webkit-reviews] review granted: [Bug 82461] [Chromium] Implement a Layout Test for editing/SurroundingText : [Attachment 149724] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 82461: [Chromium] Implement a Layout Test for editing/SurroundingText
https://bugs.webkit.org/show_bug.cgi?id=82461

Attachment 149724: Patch
https://bugs.webkit.org/attachment.cgi?id=149724&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149724&action=review


Thanks for addressing rniwa's comments.

> Source/WebKit/chromium/public/WebBindings.h:157
> +    // Return true (success) if the given npobj is a node.
> +    // If so, return that element as a WebNode object.
> +    WEBKIT_EXPORT static bool getNode(NPObject* element, WebNode*);

This is a sensible function to expose here.  It's analogous to getElement
below.

> LayoutTests/platform/chromium/fast/text/surrounding-text.html:15
> +function surroundingText(html, offset, maxLength) {

You're mixing your indent level a bit here.  We generally prefer four-space
indent.