[webkit-reviews] review denied: [Bug 89437] [GTK] Read fonts path in DRT from alternative fonts dir when main dir doesn't exist : [Attachment 150391] Updated patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 89437: [GTK] Read fonts path in DRT from alternative fonts dir when main
dir doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=89437

Attachment 150391: Updated patch
https://bugs.webkit.org/attachment.cgi?id=150391&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150391&action=review


This patch looks great, except that it should probably also deal with
WebKitTestRunner in
Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:176
> +    const char* webkitOutputDir = g_getenv("WEBKITOUTPUTDIR");

Perhaps you could do:

GOwnPtr<char> defaultOutputDir = g_build_filename(getTopLevelPath().data(),
"WebKitBuild");
const char* outputDirFromEnvironment = g_getenv("WEBKITOUTPUTDIR");
const char* webkitOutputDir = outputDirFromEnvironment ?
outputDirFromEnvironment : topLevelPath.get();

and avoid the duplication below?