[webkit-reviews] review granted: [Bug 89642] Web Inspector: Add requestFileContent command and fileContentReceived event : [Attachment 150361] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 89642: Web Inspector: Add requestFileContent command and
fileContentReceived event
https://bugs.webkit.org/show_bug.cgi?id=89642

Attachment 150361: Patch
https://bugs.webkit.org/attachment.cgi?id=150361&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150361&action=review


> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:528
> +    String encodedResult = base64Encode(static_cast<char*>(result->data()),
result->byteLength());

I think we will need to use FileReader::getAsText to deal with text files
encodings at some point, but we can add it later.