[webkit-reviews] review denied: [Bug 90277] Web Inspector: added DecodeImage and ResizeImage events to TimelineAgent : [Attachment 150379] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 2 02:11:04 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 90277: Web Inspector: added DecodeImage and ResizeImage events to
TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90277

Attachment 150379: Patch
https://bugs.webkit.org/attachment.cgi?id=150379&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150379&action=review


> Source/WebCore/ChangeLog:46
> +2012-06-29  Sergey Rogulenko  <rogulenko at google.com>

You should only include one change log entry.

> Source/WebCore/inspector/InspectorTimelineAgent.h:103
> +    static void willDecodeImage(const LayoutRect&);

Timeline should not expose public instrumentation methods to outside
WebCore/inspector.


More information about the webkit-reviews mailing list