[webkit-reviews] review requested: [Bug 90338] [V8Binding] Merging v8NumberArray() and v8NumberArrayToVector() to v8Array() and toNativeArray() respectively. : [Attachment 150367] updatedPatch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 2 00:09:05 PDT 2012
Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked for review:
Bug 90338: [V8Binding] Merging v8NumberArray() and v8NumberArrayToVector() to
v8Array() and toNativeArray() respectively.
https://bugs.webkit.org/show_bug.cgi?id=90338
Attachment 150367: updatedPatch
https://bugs.webkit.org/attachment.cgi?id=150367&action=review
------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
Thanks haraken for clarifying.
Updated patch with traits name V8ValueTraits and NativeValueTraits.
For JSC side changes I think we have custom call jsUnsignedLongArrayToVector()
for "unsigned long",
I think we can merge this too, so I will rename JSC's traits in another patch.
More information about the webkit-reviews
mailing list