[webkit-reviews] review denied: [Bug 89840] [WK2][EFL] Implement accelerated compositing on WK2 Efl port : [Attachment 149213] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 1 19:15:20 PDT 2012


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied  review:
Bug 89840: [WK2][EFL]  Implement accelerated compositing on WK2 Efl port
https://bugs.webkit.org/show_bug.cgi?id=89840

Attachment 149213: patch
https://bugs.webkit.org/attachment.cgi?id=149213&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149213&action=review


Set r- because of mentioned comments.

> Source/WebKit2/UIProcess/API/efl/ViewportProcessor.cpp:33
> +    , m_scaleFactor(1)

Is 1.0 correct ?

> Source/cmake/FindOpenGL.cmake:41
> +  IF (APPLE)

Is this correct macro ? I didn't see (APPLE) macro in CMake before.


More information about the webkit-reviews mailing list