[webkit-reviews] review requested: [Bug 90303] [chromium] Create a WebKit::Web* wrapper for the cc animation classes : [Attachment 150345] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 1 16:51:21 PDT 2012


vollick at chromium.org has asked	for review:
Bug 90303: [chromium] Create a WebKit::Web* wrapper for the cc animation
classes
https://bugs.webkit.org/show_bug.cgi?id=90303

Attachment 150345: Patch
https://bugs.webkit.org/attachment.cgi?id=150345&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #14)
> (From update of attachment 150322 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=150322&action=review
>
> > Source/Platform/chromium/public/WebTimingFunctionType.h:30
> > +enum WebTimingFunctionType {
>
> I don't think this enum really stands on its own - when you know it's part of
an animation system it makes sense, but as just a standalone header in the
Platform APi it seems odd.  It looks like it's only used in subclasses of
WebAnimationCurve, could this perhaps be an enum in this class?

Sounds good -- done.


More information about the webkit-reviews mailing list